Re: 2.6.24-rc1, sata_nv: MCP51 is boned with SWNCQ too

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bartlomiej Zolnierkiewicz wrote:
@@ -2379,9 +2379,13 @@ static int nv_init_one (struct pci_dev *
 	if (type == CK804 && adma_enabled) {
 		dev_printk(KERN_NOTICE, &pdev->dev, "Using ADMA mode\n");
 		type = ADMA;
+	} else if (type == GENERIC && swncq_enabled) {
+		dev_printk(KERN_NOTICE, &pdev->dev, "Using SWNCQ mode\n");
+		type = SWNCQ;
 	}


If we want to start putting PCI_ANY_ID entries in the pci_device_id table (as other NVIDIA patches have proposed), I don't think it's safe to assume that all devices marked GENERIC can do SWNCQ, while it should be safe to fall back from SWNCQ to GENERIC. GENERIC is the selection being considered for use as being compatible with future chips.

But overall both patches look straightforward...

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux