Re: [PATCH 12/15] ide: remove ->dma_master field from ide_hwif_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 01 October 2007, Jeff Garzik wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use
> >   pci_resource_start(hwif->pci_dev, 4) instead of hwif->dma_master.
> 
> Before using pci_resource_start(), the code should check 
> pci_resource_len() to ensure it is the appropriate size.
> 
> It would be very wise to ensure that pci_resource_flags()&IORESOURCE_IO 
> is true, too.

Sure but since the old code hasn't been doing these checks (old code
just did pci_resource_start() -> hwif->dma_base -> hwif->dma_master)
this is a separate issue from what the patch tries to achieve.

Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux