Re: Polling (was Re: [PATCHSET 2/2] implement PMP support, take 6)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
> Polling ALREADY makes the job of fixing SAS/SATA exception handling
> difficult.  Expanding polling to something SAS/SATA controllers treat as
> fundamentally irq-driven and integrated with the rest of the command
> flow is moving in the wrong direction.
> 
> To re-re-re-summarize, polling in PMP is fundamentally broken for an
> ENTIRE CLASS OF HARDWARE that we actively support today.  And
> jgarzik/misc-2.6.git#sas is adding two more controllers to that list.

As an interim solution, it doesn't make anything worse tho.  Those
drivers don't support PMP anyway.  After rc1 merge, polling PMP access
can be replaced with new qc_issue (probably ata_exec_internal) based code.

The question here is whether it's worth to include PMP support with
polling PMP register access as an interim solution for 2.6.24.  I think
it will be beneficial for both user convenience and testing as long as
the said change is made soon after -rc1.

My vote is yes but this kind of decision ultimately falls on the
subsystem maintainer, so it's your call, Jeff.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux