Alan Cox wrote:
Jeff, seeing as Tejun's commitment is never in doubt here,
I really believe we should go with the existing PMP patchset
for 2.6.24 (unless the respin happens quickly enough).
This functionality is way overdue, and we shouldn't be impeding it
as long as we have been.
I would second this. Its far too important to not get this stuff upstream
and usable NOW. Yes the model will have to change a bit but the entire
libata today has almost no resemblence to the one a year ago.
It can evolve and then the old one can die off just as we did with EH
(except for libsas anyway)
I certainly deserve plenty of blame for not catching this fact earlier,
much to my chagrin. But there are real technical issues at hand:
Polling ALREADY makes the job of fixing SAS/SATA exception handling
difficult. Expanding polling to something SAS/SATA controllers treat as
fundamentally irq-driven and integrated with the rest of the command
flow is moving in the wrong direction.
To re-re-re-summarize, polling in PMP is fundamentally broken for an
ENTIRE CLASS OF HARDWARE that we actively support today. And
jgarzik/misc-2.6.git#sas is adding two more controllers to that list.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
