Re: [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2007-07-22 at 20:33 +0200, Bartlomiej Zolnierkiewicz wrote:
> Upper layers are responsible for controlling nIEN so don't clear nIEN after
> command execution in pmac_ide_do_setfeature().

Same comment as before regarding the weirdo drive in the wallstreet. I
need to do some tests.

Ben.

> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> ---
>  drivers/ide/ppc/pmac.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: b/drivers/ide/ppc/pmac.c
> ===================================================================
> --- a/drivers/ide/ppc/pmac.c
> +++ b/drivers/ide/ppc/pmac.c
> @@ -555,7 +555,6 @@ pmac_ide_do_setfeature(ide_drive_t *driv
>  	result = __ide_wait_stat(drive, drive->ready_stat,
>  				 BUSY_STAT|DRQ_STAT|ERR_STAT,
>  				 WAIT_CMD, &stat);
> -	hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
>  	if (result)
>  		printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready "
>  			"after SET_FEATURE !\n", drive->name);

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux