Sergei Shtylyov wrote:
The code indeed does seem meaningless. For the libata it could make
sense to set bit 2 for the hardreset -- but then sil680_error_handler()
needs to be turn into ata_bmdma_drive_eh(ap, ata_std_prereset,
ata_std_softreset, sil680_bus_reset, ata_std_postreset)...
Presuming bit 2 == hardreset... correct.
In some datasheets it is not clear whether this means resetting the
silicon's ATA state machine, or truly hard-resetting the port. There is
occasionally a difference. I do not remember if Sil680 is one of those.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html