Re: [PATCH/RFC 7/9] libata: pdc_freeze() semantic change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Albert Lee wrote:
> Patch 7/9:
> 
>  After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze()
> do more than simple irq masking. Remove the DMA disable code from pdc_freeze().
> 
> The question is the design/semantic of freeze()/thaw().
> Maybe we should limit them to simple irq on/off?

Yeap, we can do that but if we do so it would be better to use
->irq_off/->irq_on hooks and kill ->freeze/->thaw.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux