Patch 7/9: After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() do more than simple irq masking. Remove the DMA disable code from pdc_freeze(). The question is the design/semantic of freeze()/thaw(). Maybe we should limit them to simple irq on/off? Signed-off-by: Albert Lee <albertcc@xxxxxxxxxx> --- diff -Nrup 06_add_freeze_thaw_to_lldd/drivers/ata/sata_promise.c 07_sata_promise_freeze/drivers/ata/sata_promise.c --- 06_add_freeze_thaw_to_lldd/drivers/ata/sata_promise.c 2007-06-11 17:23:47.000000000 +0800 +++ 07_sata_promise_freeze/drivers/ata/sata_promise.c 2007-06-13 13:39:33.000000000 +0800 @@ -581,7 +581,6 @@ static void pdc_freeze(struct ata_port * tmp = readl(mmio + PDC_CTLSTAT); tmp |= PDC_IRQ_DISABLE; - tmp &= ~PDC_DMA_ENABLE; writel(tmp, mmio + PDC_CTLSTAT); readl(mmio + PDC_CTLSTAT); /* flush */ } - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
