Hi, On Wednesday 16 May 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > >>There's no reason to have the speedproc() method wrapper for the two quite > >>different chip families, so just get rid of it. > > >>Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> > > > applied > > I forgot to notice/mention the side effect: there would be no speedproc() > method installed if hwif->dma_base happens to be 0. It doesn't sound too nice since ->autotune is always set and ->tuneproc uses ->speedproc unconditionally (=> OOPS). Looks like we really need an extra if (atp850) choose atp850 speedproc else choose atp86x speedproc before hwif->dma_base check... or maybe even separate ->init_hwif methods for atp850 and atp86x. Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
