Re: [PATCH 2.6.22-rc2] libata: sata_sis fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> the pata133 sis controllers does not support a drive present status
> in the pci configspace like the older sis controllers, check removed.

Are you sure about this - I've no idea about the SATA/PATA combo but the
pure PATA 133Mhz (MuTOL 96x) chipsets seem to do so correctly.
 
> Signed-off-by: Uwe Koziolek <uwe.koziolek@xxxxxxx>

> +static void sis_133_error_handler(struct ata_port *ap)
> +{
> +	ata_bmdma_drive_eh(ap, ata_std_prereset, ata_std_softreset, NULL, ata_std_postreset);
> +}

NAK - if this is needed then you can simply set .error_handler to use the
default bmdma handler rather than adding the function

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux