On Wed, 11 Apr 2007 15:42:05 +0900, Tejun Heo wrote: ... > diff --git a/drivers/ata/sata_promise.c b/drivers/ata/sata_promise.c > index baa8368..8e8fe59 100644 > --- a/drivers/ata/sata_promise.c > +++ b/drivers/ata/sata_promise.c ... > @@ -333,7 +349,7 @@ static struct pci_driver pdc_ata_pci_driver = { > }; > > > -static int pdc_common_port_start(struct ata_port *ap) > +static int pdc_pata_port_start(struct ata_port *ap) > { > struct device *dev = ap->host->dev; > struct pdc_port_priv *pp; > @@ -358,15 +374,14 @@ static int pdc_common_port_start(struct ata_port *ap) > > static int pdc_sata_port_start(struct ata_port *ap) > { > - struct pdc_host_priv *hp = ap->host->private_data; > int rc; > > - rc = pdc_common_port_start(ap); > + rc = pdc_pata_port_start(ap); NAK this rename. It's conceptually wrong to unconditionally invoke a PATA operation from a SATA operation. The old name made it clear that that operation was common for all types of ports. The rest looks good, but I'll have to take a closer look to verify the details. /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html