On Mon, 09 Apr 2007 16:52:53 +0900, Tejun Heo wrote: >Mikael Pettersson wrote: >> Promise ATA ports should always be reset by pdc_reset_port() >> when errors are detected, but the recent error reason decoding >> update to sata_promise replaced that reset with a freeze. >> >> This patch changes the error detection to do a reset again. >> This makes the error decoding update safer, as it now only >> adds error decoding without changing any other behaviour. >> >> Signed-off-by: Mikael Pettersson <mikpe@xxxxxxxx> > >Not necessarily NAK'ing but I think it's better to do things like that >in EH thread not in the interrupt handler. Isn't freezing enough in the >interrupt handler? You're right that the reset should be in the EH code. But it isn't right now (the resets done there are generic ones, not the Promise-specific one the HW really wants), so the error decoding change caused a regression that needs to be fixed. I intend to change the interrupt handler to just freeze and add a Promise-specific reset to EH in a separate patch. /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
