> pci_set_mwi() is an advisory thing, and on certain platforms it might fail > to set the cacheline size to the desired number. This is not a fatal error > and the driver can successfully run at a lesser performance level. Correct. > If that description is accurate then I'd contend that pci_set_mwi() is > misdesigned. It should not be returning a negative error code for > something which is not an error. It is an error to *some* drivers but not all. Kind of like setting some of the other features may be essential for some chips and not others. > And we *need* to be excessively anal in the PCI setup code. We have metric > shitloads of bugs due to problems in that area, and the more formality and > error handling and error reporting we can get in there the better off we > will be. No argument there If we want to deal with some of the mess we should also remove all direct writing of PCI latency timers and replace them with a function to stop drivers setting unsafe values and ignoring chip errata the core knows about but they dont - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
