Mark Lord wrote: > Mark Lord wrote: >> >> This patch corrects fill_result_tf() so that the flags >> get copied to result_tf before they are used by tf_read(). >> >> Signed-off-by: Mark Lord <mlord@xxxxxxxxx> >> --- >> --- linux/drivers/ata/libata-core.c.orig 2007-03-21 >> 12:46:06.000000000 -0400 >> +++ linux/drivers/ata/libata-core.c 2007-04-02 16:16:28.000000000 >> -0400 >> @@ -4763,8 +4763,8 @@ >> { >> struct ata_port *ap = qc->ap; >> >> - ap->ops->tf_read(ap, &qc->result_tf); >> qc->result_tf.flags = qc->tf.flags; >> + ap->ops->tf_read(ap, &qc->result_tf); >> } >> >> /** >> > > If I understand this correctly, the impact of (not patching) this > is that error-handling for LBA48 accesses is broken. Right, Tejun? Yes, you're right. Thanks for fixing this. Acked-by: Tejun Heo <htejun@xxxxxxxxx> -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html