Re: [PATCH libata-dev#upstream-fixes] libata: IDENTIFY backwards for drive side cable detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Cox wrote:
> On Thu, 22 Mar 2007 22:24:19 +0900
> Tejun Heo <htejun@xxxxxxxxx> wrote:
> 
>> For drive side cable detection to work correctly, drives need to be
>> identified backwards such that the slave device releases PDIAG- before
>> the mater drive tries to detect cable type.  ata_bus_probe() was fixed
>> by commit f31f0cc2f0b7527072d94d02da332d9bb8d7d94c but the new EH path
>> wasn't fixed.  This patch makes new EH path do IDENTIFY backwards.
>>
>> ata_dev_configure() for new devices are still performed master first.
>> This is to keep the detection messages in forward order.
>>
>> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
> 
> Acked-by: Alan Cox <alan@xxxxxxxxxx>
> 
> Why do we have two implementations of the same code ?

ata_bus_probe() is scheduled to be killed once all old-EH code is
removed.  That's the old probe path.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux