Re: [PATCH] ide: revert "ide: fix drive side 80c cable check, take 2" for now

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bartlomiej Zolnierkiewicz wrote:
> [PATCH] ide: revert "ide: fix drive side 80c cable check, take 2" for now
> 
> "ide: fix drive side 80c cable check, take 2" patch from Tejun Heo (commit
> fab59375b9543f84d1714f7dd00f5d11e531bd3e) fixed 80c bit test (bit13 of word93)
> but we also need to fix master/slave IDENTIFY order (slave device should be
> probed first in order to make it release PDIAG- signal) and we should also
> check for pre-ATA3 slave devices (which may not release PDIAG- signal).
> 
> [ Unfortunately the fact that IDE driver doesn't reset devices itself helps
>   only a bit as it seems that some BIOS-es reset ATA devices after programming
>   the chipset, some BIOS-es can be set to not probe/configure selected devices,
>   there may be no BIOS in case of add-on cards etc. ]
> 
> Since we are quite late in the release cycle and the required changes will
> affect a lot of systems just revert the fix for now.
> 
> [ Please also see libata commit f31f0cc2f0b7527072d94d02da332d9bb8d7d94c. ]
> 
> Thanks goes out to Fernando Mitio Yamada for reporting the problem
> and patiently testing patches.
> 
> Cc: Tejun Heo <htejun@xxxxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

Ackec-by: Tejun Heo <htejun@xxxxxxxxx>

Never suspected it could cause this much problem.  :-(

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux