On Mon, 19 Mar 2007 15:37:46 +0100
Holger Macht <hmacht@xxxxxxx> wrote:
> Sure. What actually bothers me is that in its current state, the dock
> station driver signals 'green' on the dock station as soon as the user
> presses the hardware undock button, but regardlessly of anything else. I
> think it would be ok to let the ACPI undock event up to userspace because
> in many situations it knows best when it is save to undock.
I disagree - as I mentioned, not all laptops actually let you (userspace)
control the undock process because they don't lock. The dock driver
does notify user space of an undock, before it actually undocks:
/*
* here we need to generate the undock
* event prior to actually doing the undock
* so that the device struct still exists.
*/
dock_event(ds, event, UNDOCK_EVENT);
hotplug_dock_devices(ds, ACPI_NOTIFY_EJECT_REQUEST);
undock(ds);
eject_dock(ds);
We even notify other subsystems of our intent to undock prior to actually
doing it.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
