On Saturday 10 March 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > > [PATCH] siimage: fix wrong ->swdma_mask > > > This driver doesn't support SWDMA so use the correct ->swdma_mask. > > > While at it: > > > * no need to call config_chipset_for_pio() in config_chipset_for_dma(), > > if DMA is not available config_chipset_for_pio() will be called > > by siimage_config_drive_for_dma() and if DMA is available > > config_siimage_chipset_for_pio() will be called by siimage_tune_chipset() > > Ugh, this driver has such a messy code PIO-wise! There seems to be > completely no point in calling config_siimage_chipset_for_pio() from > siimage_tune_chipset(). Not mentioning that tuneproc() method fails to > actually control IORDY (it only twiddles IORDY bits for taskfile access). Ah, > and tuneproc() fails to set the drive's own mode (as usual)... :-) > I was going to post patches but then figured out that we don't actually > support this driver, so the priority has significatly dropped. :-) Does it mean that I should expect more patches for other drivers? ;-) If so I could take care of this one... :-) Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
