On Tue, Mar 06, 2007 at 11:18:36PM +0900, Tejun Heo wrote: > Actually, I have. I was thinking of higher level helpers. e.g. > pacpi_cable_detect() in libata-acpi.c such that sata_nv's cable_detect > can do. There is no cable detect feature in ACPI, you try and set a mode and if it lets you then the cable is probably there. That means you can't do "pacpi_cable_detect" easily as a helper because you will corrupt all the timing set up so far, and potentially on both drives. I guess we could carefully set PIO 0 back on both and stick big warning signs on the function about where to use it. > So that it's more robust && we don't have to alternate between sata_nv, > pata_acpi depending on BIOS/kernel configuration, and possibly combine > other low level features with ACPI support. Makes sense and its easy to move the code around once you are ready to do so. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
