Hello,
Just one nit.
Dan Williams wrote:
> + if (unlikely(status == 0xffffffff || status == 0)) {
> + status && printk(KERN_ERR DRV_NAME ": IRQ status == 0xffffffff, "
> + "PCI fault or device removal?\n");
People usually don't like using logical operator short circuit for
branching. Just put another if () and you can also use dev_printk() there.
Other than that, everything looks good. Thanks for doing this.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
