On Thu, 8 Feb 2007 20:34:53 +0000 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Feb 08, 2007 at 12:25:39PM -0800, Andrew Morton wrote: > > On Thu, 8 Feb 2007 19:42:04 +0000 > > Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > > On Thu, Feb 08, 2007 at 03:40:22PM +0800, Zhang, Yanmin wrote: > > > > If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the > > > > fixed irq number. On ia64 platform, such numbers are GSI and should be converted > > > > to irq vector. > > > > > > > > Below patch against kernel 2.6.20 fixes it. > > > > > > These direct arch ifdefs in core aren't acceptable. > > > > For 2.6.21 that's true. But this is a suitable fix for 2.6.20.x, no? > > Just putting in an #ifndef and allow to to set it up in asm/ata.h > is almost as trivial and a lot nice conceptually. Well if that's what the 2.6.21 solution looks like then OK. Would want to see the patch though. > Then again > what happened to the idea of putting fixes into mainline before > -stable? If the preferred mainline patch involves a lot of not-really-needed restructuring then an alternative short-but-obvious fix for -stable is sometimes more appropriate. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
