Jeff Garzik writes: > Mikael Pettersson wrote: > > This patch updates the sata_promise driver to use new-style > > libata error handling for 20619 (TX4000) chips. sata_promise > > already uses new EH for the other chips it supports, so the > > patch is quite simple: > > > > * remove ->phy_reset and ->eng_timeout ops from pdc_pata_ops, > > and instead bind ->freeze, ->thaw, ->error_handler, and > > ->post_internal_cmd to existing new EH functions > > * drop ATA_FLAG_SRST from board_20619's flags > > * remove now unused pdc_pata_phy_reset() and pdc_eng_timeout() > > * pdc_pata_cbl_detect() is now unused, but it contains a cable > > detection procedure that I don't think is mentioned in public > > documentation, so for now I just wrapped it with #if 0/#endif > > > > Tested on a TX4000 with both modern working disks and old/quirky > > disks. Also used a CD-RW drive to test reading and writing CDs. > > > > Signed-off-by: Mikael Pettersson <mikpe@xxxxxxxx> > > The lack of cable detection definitely sounds like a bug...? > > The standard procedure is to set ap->cbl in your 'prereset' EH hook, as > is done in drivers/ata/pata_sil680.c. Indeed. Scratch this patch. I'm sending a fix to correct this error, and will do a revised 20619 new EH patch in a couple of days when I have access to a TX4000 card again. BTW, the PATA cable detection procedure matches Promise's drivers, but the bit it checks is not described in the pdf documents. /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
