On Mon, 5 Feb 2007 21:41:06 +0900 Tejun Heo <htejun@xxxxxxxxx> wrote: > The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is > implemented. This increases the chance of incorrect wire detection > especially because host side cable detection is often unreliable and > we sometimes soley depend on drive side cable detection. Fix the test > and add word93 validity check. > > Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > --- > Thanks for pointing out, fixed accordingly. Acked-by: Alan Cox <alan@xxxxxxxxxx> > - if (dev_id[93] & 0x4000) > + if ((dev_id[93] & 0xC000) == 0x4000 && (dev_id[93] & 0x2000)) > return 0; /* 80 wire */ > return 1; Can we do if ((dev_id[93] & 0xE000) == 0x6000) - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
