On Mon, 5 Feb 2007 16:45:35 +0900 Tejun Heo <htejun@xxxxxxxxx> wrote: > The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is > implemented. This increases the chance of incorrect wire detection > especially because host side cable detection is often unreliable and > we sometimes soley depend on drive side cable detection. Fix it. NAK to the fix but not the report We must check bits 15 and 14 to know if bit 13 is valid. The old code is wrong (follows the old IDE bits) but your change is probably no better as you remove the needed validity check. if ((dev_id[93] & 0xC000) == 0x4000) && (dev_id[93] & 0x2000)) return 0; Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
