On Sat, 03 Feb 2007 01:41:41 +0900 Tejun Heo <htejun@xxxxxxxxx> wrote: > > Actually, I think ata_timing_merge() should just be performed when > > setting MWDMA mode... This should be the right thing to do in most cases > > (however, this hardware has some complications in the form of only 2-bit > > wide active/recovery counts and 2 fast timing bank select bits)... > > Yeap, that'll be nice. Dunno whether modifying piix/ata_piix too much > would be a good idea tho considering the wide usage. If I remember rightly the 2bits is ok because you can set the bit to say that timings are for DMA only, the device then uses slower than PIO0 for all other cycles. > In both mwdma and pio cases, they're just turning off UDMA. Don't know > whether it's actually necessary but still afraid to change it unless > there is a good reason. The tuning manual I have does it, so I do it 8) Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
