Sergei Shtylyov wrote:
>> + /* PIO configuration clears DTE unconditionally. It will be
>> + * programmed in set_dmamode which is guaranteed to be called
>> + * after set_piomode if any DMA mode is available.
>> + */
>
> Actually, I think ata_timing_merge() should just be performed when
> setting MWDMA mode... This should be the right thing to do in most cases
> (however, this hardware has some complications in the form of only 2-bit
> wide active/recovery counts and 2 fast timing bank select bits)...
Yeap, that'll be nice. Dunno whether modifying piix/ata_piix too much
would be a good idea tho considering the wide usage.
>> pci_read_config_word(dev, master_port, &master_data);
>> if (is_slave) {
>> + /* clear TIME1|IE1|PPE1|DTE1 */
>> + master_data &= 0xff0f;
>
> Yeah, I've fixed this oversight in piix.c...
Great, please consider updating ata_piix together next time. libata can
really use some help from a someone who knows a lot about PATA including
mode programming.
>> + if (ap->udma_mask) {
>> + udma_enable &= ~(1 << devid);
>> + pci_write_config_word(dev, master_port, master_data);
>> + }
>
> I've also noticed that this is done at the end of piix_set_piomode()
> and I see no reason why. Isn't it just a leftover from the piix.c
> brokenness? This driver coupled PIO and UDMA timing updates for no
> conceivable reason?
In both mwdma and pio cases, they're just turning off UDMA. Don't know
whether it's actually necessary but still afraid to change it unless
there is a good reason.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
