Problem: IDE ATAPI DMA lost irq with CDB intr devices on Intel ICHx machines.
This patch clears the INTR and ERROR bits of DMA status before starting BMDMA
to fix the problem.
Signed-off-by: Albert Lee <albertcc@xxxxxxxxxx>
---
ATAPI DMA irq lost when testing Intel ICHx with CDB-intr CD-ROM drives:
Jan 18 18:08:48 p4ht-s kernel: ide-cd: cmd 0x28 timed out
Jan 18 18:08:48 p4ht-s kernel: hdc: DMA interrupt recovery
Jan 18 18:08:48 p4ht-s kernel: hdc: lost interrupt
Jan 18 18:08:48 p4ht-s kernel: hdc: status timeout: status=0xd0 { Busy }
Jan 18 18:08:48 p4ht-s kernel: ide: failed opcode was: unknown
Jan 18 18:08:48 p4ht-s kernel: hdc: DMA disabled
Jan 18 18:08:48 p4ht-s kernel: hdc: drive not ready for command
Jan 18 18:08:48 p4ht-s kernel: hdc: ATAPI reset complete
The problem is reported by Adam Hawks.
It seems the the INTR bit was set to 1 by the CDB-intr before the DMA is started.
ICHx doesn't like it and causes the DMA irq lost later.
The patch is against 2.6.20-rc5. Tested ok on ICH4.
====================================================================
--- ide-dma.ori/drivers/ide/ide-dma.c 2006-11-30 05:57:37.000000000 +0800
+++ ide-dma/drivers/ide/ide-dma.c 2007-01-18 18:40:18.000000000 +0800
@@ -591,6 +591,12 @@ void ide_dma_start(ide_drive_t *drive)
{
ide_hwif_t *hwif = HWIF(drive);
u8 dma_cmd = hwif->INB(hwif->dma_command);
+ u8 dma_stat = hwif->INB(hwif->dma_status);
+
+ /* The intr bit of dma_status might has been set by the CDB interrupt.
+ * Clear the INTR & ERROR bits here to prevent DMA irq lost later.
+ */
+ hwif->OUTB(dma_stat|6, hwif->dma_status);
/* Note that this is done *after* the cmd has
* been issued to the drive, as per the BM-IDE spec.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
