Robert Hancock wrote:
-In the error_handler function the code would always go through and do an ADMA channel reset and also dump out the state of all the CPBs. This reset seems heinous in this situation since we haven't even decided to reset anything yet. The output seems redundant at this point since libata already dumps the state of all active commands on errors (and it also triggers at times when it shouldn't, like when suspending). Do the ADMA reset only on hardreset and remove the output.
Actually, upon further thought some of this stuff really should be done in the error_handler method, just maybe not the channel reset. I'll cut another patch shortly.
- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
