On 1/9/07, Conke Hu <conke.hu@xxxxxxxxx> wrote:
On 1/7/07, Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote:
> On 1/6/07, Conke Hu <conke.hu@xxxxxxxxx> wrote:
> > A previous patch to atiixp.c was removed but some code has not been
>
> This one?
>
> http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ab17443a3df35abe4b7529e83511a591aa7384f3
>
> Doesn't it break existing setups without giving ANY warning?
>
> theoretical (I don't have hardware in question) scenario:
> - user uses atiixp and has modular libata/ahci (or no libata/ahci et all)
> - user does kernel upgrade
> - boot fails
> - ...
>
> If this is true please add something like
>
> printk(KERN_WARNING "PCI: setting SB600 SATA to AHCI mode"
> " (please use ahci driver instead of atiixp)\n");
>
> to quirk_sb600_sata() so people will at least know what is wrong...
>
> > cleaned. Now we remove these code sine they are no use any longer.
>
> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
>
> [ but the patch is line wrapped and unfortunately doesn't apply ]
>
> PS: please always cc: linux-ide@xxxxxxxxxxxxxxx on PATA/SATA patches
>
> Thanks,
> Bart
>
Hi Bart,
I've tried to access the following link to make sure which it is,
but failed. The internet here is almost broken.
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ab17443a3df35abe4b7529e83511a591aa7384f3
Yeah, kernel.org is heaving some load related problems.
I sent out 2 patches for the same SB600 legacy IDE issue. the later
(sb600 pci qurik) is better so we should clean the previous patch
which was applied to atiixp.c. -- that is what this patch does.
Yep, I was talking about "PCI: ATI sb600 sata quirk" which was merged
into -rc2.
BTW, I re-create and re-send the patch (see below) based on
2.6.20-rc4, in last patch I fogot to rename atiixp.c.1 to atiixp.c
which may lead to patch fail, nothing else different.
And maybe no need to re-ACK if last one is accepted:)
As stated in the other mail - these patches are in -mm kernel already.
Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
