Mark Lord wrote: > Tejun Heo wrote: >> 'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely >> spread yet leaving no easy way to access ATAPI IDENTIFY data. >> Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works. > > Mmm.. I still think this old ioctl is ugly, and I'd rather > have things fixed so that "hdparm -I" works instead. Me agrees. Please drop HDIO_GET_IDENTITY patch. > Unless having access to the libata cached ID block is useful > beyond just getting ATAPI drives to work with -I. > Is it? I suppose it might be useful to be able to look at it. No, it's just to allow access to ATAPI IDENTIFY block. libata does pretty good job of keeping ID block in sync via revalidating, so they should be the same. > hdparm *does* try to issue the PACKET IDENTIFY whenever > a regular IDENTIFY fails. Currently these all go through > the HDIO_DRIVE_CMD ioctl(). I don't have a system set up > here that has any ATAPI over libata to test with. > Could you perhaps try and see where that ioctl() is failing? Ah.. Okay, so that's the second HDIO_DRIVE_CMD. I'll test why the second one is failing tomorrow. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
