Without this patch, G5 oopses on boot. I've had this in Ubuntu since 2.6.17, but I forgot it was in there. Still required with 2.6.20. Signed-off-by: Ben Collins <bcollins@xxxxxxxxxx> diff --git a/drivers/ata/sata_svw.c b/drivers/ata/sata_svw.c index d89c959..85911b4 100644 --- a/drivers/ata/sata_svw.c +++ b/drivers/ata/sata_svw.c @@ -473,11 +473,11 @@ static int k2_sata_init_one (struct pci_ pci_set_master(pdev); - /* FIXME: check ata_device_add return value */ - ata_device_add(probe_ent); - kfree(probe_ent); + if (ata_device_add(probe_ent)) + return 0; - return 0; + /* Failed to add, no device present */ + rc = -ENODEV; err_out_free_ent: kfree(probe_ent); - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
