Tejun Heo wrote:
Instead of writing 0xf blindly, preserve the content of write-once PORTS_IMPL register over host resets. This patch is taken from Jeff Garzik's AHCI init update patch. Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> Cc: Jeff Garzik <jgarzik@xxxxxxxxx>
One reason why I didn't go ahead and apply this is for uninitalized-by-BIOS cases that are the reason I originally hardcoded a 0xf value into the register.
This patch is OK, iff we also include a test to see if impl_save==0 prior to global reset. If that is the case, we should hardcode 0xf or (1<<n_ports)-1
Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html