[cc'ing linux-ide again] Fajun Chen wrote:
Hi Tejun, Your patch is successful at fixing the kernel error when adding pata drive on 2.6.18-rc2 but there's some sg availability issue. I did the same sequence of test: power off drive -> remove drive -> power on drive -> add drive. From dmesg log, pata drive was added back successfully as sg0 but somehow it is unavailable for upper level. For instance, sg_scan didn't detect it. It is not shown in /sys/class/scsi_generic/. Sg utilities sg_inq and sg_dd complained about no such device for sg0. Is there any magic command I need to issue to populate sg information up to the user space? If not, then there is still bug somewhere. Complete log of the test sequence is attached. I'll hold off the testing on 2.6.18-rc4 for now. Please let me know if you think it still makes sense to test your patch in the new release. Thanks for your help!
The thing is that the patch shouldn't really change behavior. With the patch, libata might be more forgiving about SCSI refcnt bugs but the code before and after are identical correctness-wise. ISTR there has been SCSI ref bug fixed sometime inbetween. I can't pinpoint it though. So, please try 2.5.18-rc4 w/ or w/o the patch. Pull libata-dev#pata-drivers, that's basically current linus #master + libata-dev#upstream updates + Alan's pata-drivers.
Of course, I might be wrong, but I kind of have too little lead to follow on at the moment, especially because I can't reproduce it here. If testing new kernel on your target platform takes a lot of effort, just perform preliminary tests on x86. As far as SCSI and libata are concerned, there's little difference.
-- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
