There have been a number of reports regarding some ICH5s failing to
detect devices since the PCS handling update. Analysis shows that
these problems are caused by bogus PCS values from those controllers.
Before the PCS update, the driver didn't honor PCS regs exactly and
probed them in many cases PCS reports no device. Now that PCS is
honored exactly, these hardware problems are visible.
This patch makes ICH5 ignore PCS.
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
---
Keith Owens, Steve and Andre, please test this patch and report how
this works for you guys. If possible, please test with several
different setups. Some ICHs (7 and 8) suffer from long boot delays
due to ghost device if PCS is not honored and we want to make sure
that ICH5 doesn't have that problem.
ICH7 and 8's choke if the master device is ATAPI and the slave slot is
empty, so testing this case on ICH5 would be especially helpful.
e.g. If your ata_piix reports [P0 P1 IDE IDE], connect SATA ATAPI
device to SATA port 0 and don't connect anything to P1, boot and see
if things work okay.
This patch is against libata-dev#upstream-fixes and should apply to
2.6.18-rc4 and the current linus #master.
Thanks.
diff --git a/drivers/scsi/ata_piix.c b/drivers/scsi/ata_piix.c
index 01b3530..3b98f18 100644
--- a/drivers/scsi/ata_piix.c
+++ b/drivers/scsi/ata_piix.c
@@ -390,7 +390,8 @@ #endif
/* ich5_sata */
{
.sht = &piix_sht,
- .host_flags = ATA_FLAG_SATA | PIIX_FLAG_CHECKINTR,
+ .host_flags = ATA_FLAG_SATA | PIIX_FLAG_CHECKINTR |
+ PIIX_FLAG_IGNORE_PCS,
.pio_mask = 0x1f, /* pio0-4 */
.mwdma_mask = 0x07, /* mwdma0-2 */
.udma_mask = 0x7f, /* udma0-6 */
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
