Re: [PATCH 1/n] libata-core.c conversion to new debugging scheme, part 1 (25% done)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Borislav Petkov wrote:
This patch converts the first 25% of libata-core.c to the new debugging scheme.

Signed-off-by: <petkov@xxxxxxxxxxxxxxx>

After I hand-applied a lot of this, and looked at the result, I would request further updates:

1) The message level order is a bit off. Following the original Becker-designed strategy (netif.txt), the ATA_MSG_xxx bits should be ordered in order of verbosity, where that order is passed to ata_msg_init() from the user.

This implies that that ATA_MSG_ERR (the most important) should be 0x1, _WARN should be 0x2, PROBE(?), DRV(?), and so on.

2) rediff and resend this "part 1" patch against the latest libata-dev.git#upstream, which looked mostly OK

	Jeff


-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux