On Fri, 2006-06-02 at 10:14 +0200, Hannes Reinecke wrote: > Did you actually test with staggered-spinup and/or cold-presence > detection? I just added them per spec but never got a chance to test > them here. We have no mobile platform in our lab, which support staggered-spinup or cold presence detection. I would test it when the newest chipset is available. > And: it might be an idea to rename the HOST_CAP bits to be consistent > with those printed during initialisation. It's bad enough as it is (ie > the spec uses different abbrevs than the implementation), but we should > try to be consistent within the implementation. > I would rename them to HOST_CAP_STAG and HOST_CAP_SLUM. Agree. When reading code, I need to translate the MACRO into the abbrevs in spec to understand the meaning. > Add slumber mode: libata-core used to issue a port reset with an > implicit SLUMBER/PARTIAL mode disable. So after a reset we might not be > able to put the device into SLUMBER mode even if supported. > What was the reasoning for this? I have the same question. Maybe the original author of libata-core.c can help answer it. - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
