zhao, forrest wrote: > Put port power management[1], staggered-spinup[2], cold presence > detection[3] related operations during the power state transition into > ahci_port_standby() and ahci_port_spinup(). > > In particular ahci_port_standby() does the [1] and [2] when power transits > to a lower level; ahci_port_spinup() does [1], [2] and [3] when power > transits to a higher level. > Did you actually test with staggered-spinup and/or cold-presence detection? I just added them per spec but never got a chance to test them here. And: it might be an idea to rename the HOST_CAP bits to be consistent with those printed during initialisation. It's bad enough as it is (ie the spec uses different abbrevs than the implementation), but we should try to be consistent within the implementation. I would rename them to HOST_CAP_STAG and HOST_CAP_SLUM. Add slumber mode: libata-core used to issue a port reset with an implicit SLUMBER/PARTIAL mode disable. So after a reset we might not be able to put the device into SLUMBER mode even if supported. What was the reasoning for this? Cheers, Hannes -- Dr. Hannes Reinecke hare@xxxxxxx SuSE Linux Products GmbH S390 & zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
