Hello, Zhao.
zhao, forrest wrote:
[--snip--]
> diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c
> index 9e5cb9f..810f42e 100644
> --- a/drivers/scsi/libata-scsi.c
> +++ b/drivers/scsi/libata-scsi.c
> @@ -1269,6 +1269,17 @@ static void ata_scsi_qc_complete(struct
> u8 *cdb = cmd->cmnd;
> int need_sense = (qc->err_mask != 0);
>
> + /* We snoop the SET_FEATURES - Write Cache ON/OFF command, and
> + * schedule EH_REVALIDATE operation to update the IDENTIFY DEVICE
> + * cache
> + */
> + if ((!(cdb[2] & 0x20)) && (qc->tf.command == ATA_CMD_SET_FEATURES) &&
!(cdb[2] & 0x20) seems out of place, and revalidation should be
scheduled only when the qc is completing successfully. ie. !need_sense,
but if used that way the variable name doesn't make much sense. IMHO,
renaming it to something like failed would be better.
> + ((qc->tf.feature == SETFEATURES_WC_ON) ||
> + (qc->tf.feature == SETFEATURES_WC_OFF))) {
> + qc->ap->eh_info.action = ATA_EH_REVALIDATE;
Please do action |= ATA_EH_REVALIDATE. Also, above schedules
revalidation for both devices for a PATA port. Currently, there is no
way to specify which device is offending from qc completion path. I'll
submit a patch to allow it. After the patch, please add
qc->ap->eh_info.dev = qc->dev such that only the affected device is
revalidated.
Thanks.
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
