On Wed, May 31, 2006 at 07:46:33AM +0200, Borislav Petkov wrote: > This patch converts the first 25% of libata-core.c to the new debugging scheme. > > Signed-off-by: <petkov@xxxxxxxxxxxxxxx> Looks good at first glance, though I'll hold off on apply until I return from the Red Hat Summit in Nashville. It made me remember another point, though: in order to avoid regressions, after applying your patch, I would think that you would want to create a patch which did something like #ifndef ATA_VERBOSE_DEBUG ap->msg_enable = xxx #else ATA_DEBUG ap->msg_enable = yyy #else ap->msg_enable = ... #endif Thus, we are assured that applying your patch will not change the behavior(much?) when ATA_VERBOSE_DEBUG is enabled. Regards, Jeff - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
