Re: [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
* I've renamed ata_hotplug_wq to ata_scsi_wq in hotplug patches. I think rescan can use this wq instead of creating its own.

I think we will use this workqueue even when SCSI is optional, so ata_scsi_wq may not be the best name, long term. I ACK'd its inclusion of course, so not a big deal.

As it seems there will be another round of hotplug patches, I can rename it without too much trouble. My candidates are...

ata_aux_wq
ata_management_wq / ata_mgmt_wq
ata_errands_wq

Another thing to consider is using the kthread API, ignore workqueues, and simply creating "one-shot" threads as needed.

It wouldn't work for SCSI hotplug. It depends on that there is only one thread running the thing, so I think wq is the better choice. Any suggestion on naming?

--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux