Re: [PATCH 07/12] libata-hp-prep: store attached SCSI device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
Tejun Heo wrote:
dev->sdev doesn't hold reference to the SCSI device.  It's cleared
when the SCSI device goes away.

ACK patches 5-7, though I consider the above quoted statement somewhat questionable... _why_ not hold a reference?

libata shouldn't affect the lifetime of the scsi device. When the sdev disappears, dev->sdev should go too. It's easy to carry an extra reference but it wouldn't mean anything - the reference will be increased on attach and should be decreased with the device lifetime reference, so I thought it would be better to make it explicit that libata doesn't affect sdev's lifetime by not holding any extra reference to it.

--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux