Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
+static int ata_boot_probe_wait(void *dummy)
+{
+ schedule();
schedule_timeout(1) is preferred
Can you elaborate? AFAICS, the function is entered in
TASK_UNINTERRUPTIBLE state. No busy looping there. It's called from
wait_on_bit() which takes care of sleep/wakeup conditions.
Well, the purpose is to _wait, and so schedule_timeout() is more
appropriate than schedule(). I also that an unconditional schedule() is
a bit unfriendly if there is nothing useful to schedule at the moment.
Jeff
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
