Alan Cox wrote: > On Maw, 2006-05-23 at 07:44 -0700, Tejun Heo wrote: >> Waiting for spinup is common operation for both PATA and SATA although I >> don't know how many PATA controllers support hotplug. > > Most do, but few vendors ship the required extra buffers for many of the > chips. Unfortunately it means we have to add code for lots of chips each > with few hot/warmplug users 8( > > >> ata_port_offline() applies to both PATA and SATA. It's just that the >> current implmentation always returns 0 for PATA. Well, I don't know. >> Maybe we should rename all those to sata_*() and rename them again when >> actual PATA support is implemented. >> > > What is ata_port_offline() intended to do ? > ata_port_online(@ap) returns 1 if @ap knows that one or more devices are attached to it; otherwise, 0 ata_port_offline(@ap) returns 1 if @ap knows that no device is attached to it; otherwise, 0 With later ata_link addition, above functions are changed to ata_link_on/offline(@link) respectively. -- tejun - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html