Mark Lord wrote:
Jeff Garzik wrote:
As mentioned elsewhere, Linus's patch falls over when we start
resuming controllers with real SATA phy registers, so that would be a
separate sata_pci_device_resume() function.
But does it fall over any worse than we already do with the stock kernel?
Are you talking about my x86-64 box + Linus's patch, or the future
implications?
For the former, the previous behavior was EH spew like what you are
seeing. After apply Linus's patch, it hardlocks. But I don't want that
to hold up the patch... libata suspend/resume is one part luck, and one
part "it's only ata_piix so far." It has a looooong way to go before it
is usable outside of that domain.
For the latter, it doesn't make sense to poll BSY on modern SATA
controllers, particularly (a) FIS-based ones and more importantly (b)
devices attached behind a Port Multiplier.
Jeff
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
