Re: [PATCH] Add ata_piix's own resume function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jens Axboe wrote:
Since there's just the one device on the bus in this case, whether its

Wrong.  ata_piix must deal with master/slave, as must libata itself.


the device or bus posting BUSY seems pretty irrelevant. If anything, I'd
say that the act of iterating over possible devices hanging of the pci
device and resuming them from the pci handler is definitely the worst
approach. The pci driver resume function should do just one thing --
resume the device itself.

Who resumes the bus?  hmmm?

Please, read other drivers. Control flow always starts at driver::resume, and since the driver knows the hardware best, it _must_ be the one that directs the control flow.

	Jeff


-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux