Re: [PATCH 11/14] libata-hp-prep: make ops->tf_read() optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tejun Heo wrote:
Not all controllers have single TF image and ops->tf_read() is
inappropriate for them.  Newly implemented hotplug probing will allow
drivers for such controllers to get rid of ops->tf_read() completely.
Make ops->tf_read() optional in core layer.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>

NAK.

At the present time, the controller model expects to be able to obtain correct values from the shadow registers. For FIS-based controllers, this may imply that the driver needs to maintain an accurate shadow register image, if the chip doesn't automatically supply one.

I think this is a quite reasonable expectation, given that ATA continues to have specifically defined shadow register outputs, and even in the face of NCQ, we have defined states where the shadow registers are available.

On this basis, attempts to make ->check_status() optional are also NAK'd.

	Jeff



-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux