Jeff Garzik wrote:
Tejun Heo wrote:
Yeah, Forrest pointed out the same thing and I've converted hotplug_wq
to single threaded variant, which should be enough for SCSI
hotplugging. For ata_wq, I think it's wiser to keep it multi-threaded
for the time being. Maybe what should be done is to allocate a single
threaded workqueue per host_set.
One thread per host_set would suck for any situation where that's doing
ATAPI or PIO tasks. Would love to find a good metric...
Dynamic pool of worker threads maybe?
$BIGNUM CPU boxes tend to have $BIGNUM GB of memories, so
multithreaded wq might not be that critical resource-wise. But,
still, inefficient
That's a bad assumption on modern machines. Think of a single 16-core,
8-thread SPARC Niagara CPU, for example :)
Yeah, that one is pretty extreme. But most mainstream machines have <=
8 threads of execution and even they are equipped with GB's of memory.
But, I do agree that we want something better.
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
