Tejun Heo wrote:
Hellooooo, all.
Finally, the last one. This is the first take of add-hotplug-support
patchset. This patchset includes 13 patches.
#01-04 implement hotplug framework
#05-07 implement warm plug (SCSI scan/delete callbacks)
#08-10 hook and activate hotplug
#11-13 add LLDD hotplug supports (PHY status change notifications)
Hotplugging is implemented as an integral part of EH. A new EH helper
ata_eh_hotplug() is defined which should be called after all regular
EH is done. LLDDs have to do very little to support hotplug.
I'm going to leave the substantive review of this patchset for the next
time it gets resent.
Overall,
* my quick review didn't turn up any obvious problems, but that was just
looking at each patch, not looking at the end result (big picture) at all.
* hotplug design I want to see is (also mentioned in another email):
1a) user requests bus scan
or
1b) hotplug interrupt
2) wait a bit, swallowing any 1a- or 1b-type events that
appear during the wait (debounce).
3) rescan bus, revalidate device(s)
I'm careful to use "revalidate", because that covers all cases:
- existing device goes away
- new device appears
- existing device "blipped", but its still there, so
we can keep talking to it.
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
