Re: [PATCH 3/3] libata: prefix sata register print outs with 0x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
Tejun Heo wrote:
Prefix SStatus and SControl values with 0x as they are hex.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>

NAK, libata always prints out device id, register, etc. values in hex. Basically anything other than things like sectors or bytes is printed in hex. Therefore, the "0x" is largely redundant.

The prefix/base is implicit in the context.


The reason why I submitted this patch was messages like the following...

ata2: SATA link down (SStatus 11 SControl 310)

When it was three digits, it was okay. But two or just one digits look just weird. Maybe what's needed is %03.

Well, no big deal either way.

--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux