On Sat, Mar 25, 2006 at 11:54:55PM +0000, Alan Cox wrote: > On Sad, 2006-03-25 at 15:12 +0900, Tejun Heo wrote: > > This patch renames ata_dev_present() to ata_dev_enabled() and adds > > ata_dev_disabled(). This is to discern the state where a device is > > present but disabled from not-present state. This disctinction is > > necessary when configuring transfer mode because device selection > > timing must not be violated even if a device fails to configure. > > This breaks the expected behaviour of ata_dev_pair(). I'd rather kept > the existing behaviour of ata_dev_present for the moment until we can > figure out what we need to do for "present but not enabled". That should > also fit the scsi layer expectations so we can correctly "offline" a > device. > Hello, Alan. Can you elaborate how ata_dev_pair() is broken by this patch? ata_dev_present() is simply renamed to ata_dev_enabled(). ata_dev_disabled() only differenciates the conditions where ata_dev_present() used to think there was no device. There should be no behavior change to existing code. Thanks. -- tejun - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
